Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates pyproject.toml for 3.11 #62

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Updates pyproject.toml for 3.11 #62

merged 2 commits into from
Dec 13, 2023

Conversation

jvanderaa
Copy link
Contributor

Fixes #60

This changes the supported version (some auto format updates as well.

@jvanderaa
Copy link
Contributor Author

Looking at the tests this should pass. So I'm not seeing what the issue is. Nautobot has a dependency of python = ">=3.8,<3.12" in the next branch. I don't see anywhere else where the tests would be getting Nautobot 2.0 from.

@glennmatthews
Copy link

2.0.0b1 didn't support python 3.11 yet. That was a more recent change. You might need to wait until b3 or rc1 before making this update.

@jvanderaa
Copy link
Contributor Author

@glennmatthews my latest dev host is Python3.11. In order to get to the poetry shell I need to be able to install. I can always move back to the NTC machine though as well, but this should catch things up.

@abates
Copy link
Contributor

abates commented Aug 14, 2023

@jvanderaa do we need to do anything with this, or can it wait until a release of 2.0 comes out support Python 3.11? If you have Python 3.9 or 3.10 installed on your system then I think you can use them with something like the following:

poetry env use python3.9

@jvanderaa
Copy link
Contributor Author

I just am unable to develop on my development workstation (Debian 12) until then. It's a personal preference thing, so I can move to developing elsewhere.

But the real process is that we should not rely on invoke in a virtual environment and that should be moved to using system python. This is a thing today with Python3.11 that will go away, but then when 3.12 and 3.13 come out it will be the same. We should migrate away from using invoke in virtual environments.

@jvanderaa
Copy link
Contributor Author

And this is fine while we have this in private. But what about when it is open source. Those that have only one dev workstation and it is modern, then we are preventing them from helping.

@abates abates merged commit b11e238 into develop Dec 13, 2023
14 checks passed
@abates abates deleted the support311 branch December 13, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Build Test Environment on Python3.11
3 participants